Handle disabled UndoManager during InlineRename#38138
Merged
JoeRobich merged 1 commit intodotnet:release/dev16.8from Oct 13, 2020
Merged
Handle disabled UndoManager during InlineRename#38138JoeRobich merged 1 commit intodotnet:release/dev16.8from
JoeRobich merged 1 commit intodotnet:release/dev16.8from
Conversation
Member
There was a problem hiding this comment.
When does this happen, and when it does how bad is the experience?
Member
Author
There was a problem hiding this comment.
Users described VS closing and restarting when this exception was thrown. Not performing this UndoTo() did not noticably change the IDE experience even when fully commented out.
c689ca2 to
976ddf7
Compare
Member
Author
|
@jasonmalinowski This is ready to review again. |
Member
Author
|
All CI legs are passing but GitHub still shows incomplete legs from when this targeted the master branch. |
ryzngard
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/943917