Update help service to account for all TypeDeclarationSyntax (namespace+record+struct) as partial type#48095
Merged
davidwengier merged 5 commits intodotnet:masterfrom Sep 28, 2020
Merged
Conversation
Youssef1313
commented
Sep 27, 2020
Comment on lines
+287
to
+288
| else if (token.Parent.GetAncestorOrThis<ClassDeclarationSyntax>() != null || | ||
| token.Parent.GetAncestorOrThis<RecordDeclarationSyntax>() != null) |
Member
Author
There was a problem hiding this comment.
@davidwengier Can we remove this else if altogether and assume "partialtype_CSharpKeyword" if SyntaxKind.PartialKeyword is found on non-MethodDeclarationSyntax.
Contributor
There was a problem hiding this comment.
what about structs/interfaces?
Member
Author
There was a problem hiding this comment.
@CyrusNajmabadi I should have caught this from my docs PR 😄
I would prefer removing the else if part then, what do you think?
Member
There was a problem hiding this comment.
Seems like TypeDeclarationSyntax covers all bases
TypeDeclarationSyntax (namespace+record+struct) as partial type
Youssef1313
commented
Sep 28, 2020
davidwengier
approved these changes
Sep 28, 2020
Member
|
Thanks! |
333fred
added a commit
that referenced
this pull request
Sep 28, 2020
…features/interpolated-string-constants * upstream/master: (1950 commits) Delete extra "Return True" (#48089) Remove unused param Extract local Update help service to account for all `TypeDeclarationSyntax` (namespace+record+struct) as partial type (#48095) Don't offer to remove as cast from using statements or declarations (#48110) Cleaner solution Update tests Don't offer to remove necessary native integer casts Fix xml attribute name classification Use switch expressions. Add test for IAsyncEnumerable<string> Fix tests Add tests Update CSharpTypeInferenceService.TypeInferrer.cs Fix failure to dispose RemoteWorkspace in tests [master] Update dependencies from dotnet/roslyn (#48072) Simplify common calls to Parallel.For with a RoslynParallel.For helper Fallback to IEnumerable<> if IAsyncEnumerable<> not found Fix cancellation handling in Parallel.For Update InferTypeInForEachStatement to respect await foreach ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel to dotnet/docs#20798