Skip to content

Implement add parameter support for target typed new#47929

Merged
allisonchou merged 3 commits intodotnet:masterfrom
allisonchou:AddParameterTargetTypedNew2
Sep 24, 2020
Merged

Implement add parameter support for target typed new#47929
allisonchou merged 3 commits intodotnet:masterfrom
allisonchou:AddParameterTargetTypedNew2

Conversation

@allisonchou
Copy link
Contributor

@allisonchou allisonchou commented Sep 22, 2020

Fixes #42559.

(Created a separate issue #47928 for the other bug mentioned in the original issue for clarity.)

@allisonchou allisonchou requested a review from a team as a code owner September 22, 2020 04:38
davidwengier
davidwengier approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting to me that it needed this much change. Is it possible for SyntaxFacts.GetObjectCreationType to do something different, so it could support implicit creation in the same way? Though getting it to return something such that GetSymbolInfo returns an INamedTypeSymbol might be impossible, I'm just thinking out loud :)

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Sep 22, 2020

It's interesting to me that it needed this much change. Is it possible for SyntaxFacts.GetObjectCreationType to do something different, so it could support implicit creation in the same way?

SyntaxFacts is just supposed to be purely syntactic, and only make it possible to treat really equivalent VB and C# constructs the same. So, in vb and C# tehre is an ObjectCreationExpressionSyntax. So SytnaxFacts allows you to operate over those same constructs agnostically. It is not for treating different language constructs in teh same language the same way.

CyrusNajmabadi
CyrusNajmabadi approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestions below.

@allisonchou allisonchou merged commit d697040 into dotnet:master Sep 24, 2020
@ghost ghost added this to the Next milestone Sep 24, 2020
@allisonchou allisonchou deleted the AddParameterTargetTypedNew2 branch September 24, 2020 04:58
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

16.9.P1

Development

Successfully merging this pull request may close these issues.

AddParameter and target-typed new

4 participants

@allisonchou @CyrusNajmabadi @davidwengier @Cosifne