Initialize FatalError handlers in VS and OOP#47554
Conversation
|
First try didn't work as expected; trying again... |
c7cd3cf to
eab0555
Compare
jaredpar
left a comment
There was a problem hiding this comment.
This is removing one of the key parts of the compiler verification in order to enable telemetry in CI. That is not the right trade off here. We should make a more targeted disabling of this rather than whole sale disable it for all tests.
Enabling telemetry in CI is a non-goal for this PR. Our intent is to enable telemetry for shipping. I'm certainly open to alternatives to fix this. |
Disable the test that hit the assert. |
3623df6 to
3cb8921
Compare
|
@jaredpar Switched to just skip that test. May need to skip more depending on how the tests go. |
This listener conflicts with ThrowingTraceListener, and significantly impairs the ability to identify test failures.
Currently the incremental parser is not producing trees with the correct text. However, this bug was introduced in the past and is failing now that debug assertions are checked in builds. See dotnet#47610
a27666d to
5045f94
Compare
|
@sharwell what is this waiting on? |
|
@333fred it still has a failing test (and possible crash), plus it needs ship room approval after it's passing |
971c35d to
81bc312
Compare
FatalErrorhandlers in VS and OOPFail integration tests immediately on command execution failure