Update CS1935 compiler message text to remove System.Core.dll reference#45920
Update CS1935 compiler message text to remove System.Core.dll reference#45920AlekseyTs merged 2 commits intodotnet:masterfrom kfechter:master
Conversation
No problem. I do have one question. The non English localization files were updated automatically when the resource file was changed. As I am not fluent enough in the languages to ensure the localizations are correct, what is the best way to ensure that all of the localization files are updated/reviewed accordingly? |
Don't worry about this, the files are automatically modified to make sure translators review the changes and make appropriate adjustments. #Closed |
If we were required to be fluent enough in all those languages to do translations, I think we would all lose our jobs 😅 |
haha, that's fair. Guess I really only needed to ask if there was anything specific I had to do in that regard. |
| <value>Could not find an implementation of the query pattern for source type '{0}'. '{1}' not found. Consider explicitly specifying the type of the range variable '{2}'.</value> | ||
| </data> | ||
| <data name="ERR_QueryNoProviderStandard" xml:space="preserve"> | ||
| <value>Could not find an implementation of the query pattern for source type '{0}'. '{1}' not found. Are you missing a reference to 'System.Core.dll' or a using directive for 'System.Linq'?</value> |
There was a problem hiding this comment.
reference to 'System.Core.dll' or a [](start = 125, length = 36)
Should we still mention references, but without any specific names? Something like: "Are you missing references to required assemblies or a using directive for 'System.Linq'?" #Closed
There was a problem hiding this comment.
That's a fair point.
I don't see any issues adding that information to the message. mentioning the reference assemblies but not specific names might make it more clear then just mentioning the using. I can make that change here in a bit.
There was a problem hiding this comment.
Got a bit sidetracked with work, but I just added this commit.
7a96e07
it changes the message to "Are you missing required assembly references or a using directive for 'System.Linq'?"
|
Done with review pass (iteration 1) #Closed |
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (iteration 2), assuming CI is passing.
|
@kfechter Would it be fine if we squash commits in the process of merging this PR? |
yeah, I don't have any issues with that. |
|
@kfechter Thanks for the contribution. |
Fixes #37165
Changes the using reference portion of the CS1935 message from 'Are you missing a reference to 'System.Core.dll' or a using directive for 'System.Linq'?' to 'Are you missing a using directive for 'System.Linq'?' and removes the references in all the comments and associated tests.