Change signature accessibility - add screenreader header for empty column#45840
Merged
allisonchou merged 1 commit intodotnet:release/dev16.7from Jul 15, 2020
Merged
Conversation
davidwengier
approved these changes
Jul 9, 2020
davidwengier
approved these changes
Jul 10, 2020
c0e3fb4 to
a957f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_queries/edit/1135706/
Description:
In #44986, a new empty column was added to the Change Signature UI that does not provide any added functionality for non-Narrator users, but provides a summary description of the row's parameters for those who do use Narrator:
This change adds a Narrator-only verbal header to the empty column.
For non-Narrator users: UI/UX will look/behave exactly the same.
For Narrator users: Narrator will now read out a header ("Parameter Summary") along with the existing summary of the row when the user focuses on a cell in the empty column.
Other notes: After discussion with our accessibility champ, Abhitej, it was determined that this is likely not a permanent fix, but enough to address the issue for now. We determined it would be best if the empty column was eventually deleted and we keep focus at a datarow level by default (currently it is cell level by default), and allow users to go to individual data cells if desired, similar to how Error List and Test Explorer behave today. However, this is more of a stretch goal (and appears more complicated, from the time I spent trying to implement this behavior), and for now the current implementation with this PR does meet the accessibility requirements and should suffice. I've opened up #45838 to track how we eventually want the accessibility UI to behave.