Skip to content

Change Signature DataGrid accessibility when navigating cells with CAPS+Arrow#44986

Merged
dpoeschl merged 2 commits intodotnet:masterfrom
dpoeschl:ChangeSigAccessibilityDataGridCells
Jun 9, 2020
Merged

Change Signature DataGrid accessibility when navigating cells with CAPS+Arrow#44986
dpoeschl merged 2 commits intodotnet:masterfrom
dpoeschl:ChangeSigAccessibilityDataGridCells

Conversation

@dpoeschl
Copy link
Contributor

@dpoeschl dpoeschl commented Jun 9, 2020 •
edited
Loading

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1135706

For non-Narrator users:

  • There's a small "empty" column to the left of the visible data now, but nothing else changes because the table is set to SelectionUnit="FullRow"

For Narrator users:

  • When the row (and therefore first cell in the row) is focused, narrator quickly reads a helpful description of the parameter. The user doesn't need to move cell-by-cell through the table.
  • Despite being SelectionUnit="FullRow", the user now can CAPS+Arrow key through the cells in the table and receive meaningful information.

Screenshot

image

@dpoeschl dpoeschl requested a review from a team as a code owner June 9, 2020 17:13
@dpoeschl dpoeschl marked this pull request as draft June 9, 2020 17:16
@dpoeschl dpoeschl marked this pull request as ready for review June 9, 2020 19:18
@dpoeschl
Copy link
Contributor Author

dpoeschl commented Jun 9, 2020

Tagging for review: @allisonchou @dotnet/roslyn-ide

@dpoeschl
Copy link
Contributor Author

dpoeschl commented Jun 9, 2020

@jinujoseph Is this okay to merge to master? Note that it contains strings that need to be localized.

@jinujoseph
Copy link
Contributor

jinujoseph commented Jun 9, 2020 •
edited
Loading

yes feel free to merge , @wli3 for your info on Loc string

@jinujoseph jinujoseph added this to the 16.7.P4 milestone Jun 9, 2020
@dpoeschl dpoeschl merged commit 331e147 into dotnet:master Jun 9, 2020
@ghost ghost modified the milestones: 16.7.P4, Next Jun 9, 2020
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
@allisonchou allisonchou mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@allisonchou allisonchou allisonchou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

16.7.P4

Development

Successfully merging this pull request may close these issues.

4 participants

@dpoeschl @jinujoseph @allisonchou @dibarbet