Add skipped failing test for IDE0044#45288
Conversation
|
@Youssef1313 Seems like IDE0044 is still firing here. |
|
Then the issue should be re-opened? |
|
@Youssef1313 The fix was made in the CodeStyle analyzer NuGet and we need to move to a newer CodeStyle package to get the fix. |
|
Aha, got it. Are there any reasons not to update? |
|
Actually, the latest ones are here: https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.CodeAnalysis.CSharp.CodeStyle |
|
@Youssef1313 eeba605 seems to be downgrading the version. Can you please upgrade to latest 3.8.x at https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.CodeAnalysis.CSharp.CodeStyle version? |
|
@mavasani The failure is still there with the 3.8.x version. What could be the issue? |
|
Updating the code style package is a bit complicated. The dotnet-format version needs to be updated at the same time to a version built from the same source, but the version numbers themselves will be different. I can check with @JoeRobich next week to see what the most recent matching pair is. |
|
Using the latest dotnet-format version doesn't seem to work. I'll wait until you check the latest matching pair. |
|
Ping @sharwell |
|
@JoeRobich can you verify the matching versions here? |
Currently dotnet-format is tracking the VS 16.7 feed, so to generate a matching version I'll need to update to the 16.8 feed and trigger an update. It will pull in the most recent 3.8.0 build. I'll reply back when a build is ready with dotnet-format version and the M.CA version used. |
|
@sharwell @Youssef1313 After updating dotnet-format to consume 3.8.0 builds, here is the matched pair. Microsoft.CodeAnalysis - 3.8.0-1.20367.11 |
|
@sharwell @JoeRobich The build is still failing. |
|
ping @sharwell @JoeRobich |
@Youssef1313 If your changes don't rely on updated dependencies then I would use the versions from master. |
|
I reverted all version updates in this PR, and skipped the new failing test. |
src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs
Outdated
Show resolved
Hide resolved
|
Please squash when merging. |
|
@333fred it should be ready to manually merge (with a squash commit per #45288 (comment)) when the build completes |
* upstream/master: (43 commits) Fix typos (dotnet#47264) Disable CS0660 where Full Solution Analysis produces a different result Pass in correct arguments to TypeScript handler Add skipped failing test for IDE0044 (dotnet#45288) Avoid first chance exception Code review feedback part 3 Update stale URLs in the readme Update IntegrationTestSourceGenerator.cs Fix comment Update IntegrationTestSourceGenerator.cs Remove unused reference to obsolete class Update nullable annotations in Classification folder Update generator public API names: (dotnet#47222) NullableContextAttribute for property parameters is from accessor (dotnet#47223) Modify global analyzer config precedence: (dotnet#45871) Skip the C# source generator integration test running for now Additional XAML LSP handlers (dotnet#47217) Remap diagnostics using IWorkspaceVenusSpanMappingService in-proc Warn on type named "record" (dotnet#47094) Bail out early before getting SyntaxTree ...
The linked issue is now closed and has
Resolution-Fixedlabel. So, this false positive should have been fixed.