Skip to content

Merge to records#44812

Merged
543 commits merged intodotnet:features/recordsfrom
agocke:merge-to-records
Jun 4, 2020
Merged

Merge to records#44812
543 commits merged intodotnet:features/recordsfrom
agocke:merge-to-records

Conversation

@agocke
Copy link
Member

@agocke agocke commented Jun 3, 2020

No description provided.

sharwell and others added 30 commits May 21, 2020 06:19
@sharwell
Merge pull request dotnet#44445 from sharwell/add-parameter
a17d627 
Update Add Parameter to support global statements
@sharwell
Remove unnecessary feature 'IOperation'
a513ac4 
This feature is always enabled.
@mavasani
Merge remote-tracking branch 'upstream/master' into RemoveLegacySuppr…
3516239 
…essions
@mavasani
Merge remote-tracking branch 'upstream/master' into RenameInSuppressM…
36a0750 
…essage
@dpoeschl
Remove unused variable
cabcfd3
@dpoeschl
Remove dead code around generating method invocations
d5133ac
@genlu
Disable test for assembly with missing ibc data
dafc955
@jcouv
Few more IDE scenarios for top-level statements (dotnet#44455)
dd7bbcb
@allisonchou
Global keyword recommender fix for and or
1b7f5df
@allisonchou
Add comment
2901aee
@mavasani
Merge remote-tracking branch 'upstream/master' into RenameInSuppressM…
2ada2b9 
…essage
@mavasani
Fix nullable annotation to match implementation
edffb8b
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/master' into addImport
54a9371
@CyrusNajmabadi
Make static
cd5afb8
@CyrusNajmabadi
Make tests clearer
7fe1797
@CyrusNajmabadi
Simplify tests
fde0f6f
@CyrusNajmabadi
Simplify tests
fa5c5f5
@CyrusNajmabadi
one parameter per line
ff746d1
@CyrusNajmabadi
Add docs
1b2540a
@CyrusNajmabadi
Add docs.
f93c5c6
@CyrusNajmabadi
use proper comparere in VB
8803b71
@CyrusNajmabadi
Add test
f069201
@CyrusNajmabadi
Add tests
3811037
@CyrusNajmabadi
Add C# test
6890284
@CyrusNajmabadi
Walk less of the tree.
7ec7d80
@CyrusNajmabadi
Tweak lookup
0aaa481
@CyrusNajmabadi
Fix compiler
7b9ba62
@333fred
Changes from feedback:
09b6462 
* Significantly expanded testing.
* Reworded exception messages.
* Simplified handling of getting semantic information in the CSharpSemanticModel.
* Added comments as appropriate.
* Added linux support for running the IOperation test hook from cli.
@333fred
Use BoundNode's WasCompilerGenerated.
1caf24a
@333fred
Fix formatting
464cbb0
msftbot[bot] and others added 7 commits June 2, 2020 18:39
Merge pull request dotnet#44783 from RikkiGibson/update-dropapp-version
90273de 
Update DropAppVersion
@CyrusNajmabadi
Only offer 'Use coalesce expression' in C#8 and above.
e26e046
@kendrahavens
Update readme (dotnet#44386)
da1bbaf
@sharwell
Merge pull request dotnet#43823 from CyrusNajmabadi/removeDuplicateBl…
f6c95ab 
…ankLines

Remove duplicate blank lines
Merge pull request dotnet#44798 from CyrusNajmabadi/featureVersion
6b3ce16 
Only offer 'Use coalesce expression' in C#8 and above.
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
da26bc3 
…601.10 (dotnet#44778)

Microsoft.DotNet.Arcade.Sdk
 From Version 1.0.0-beta.20278.5 -> To Version 1.0.0-beta.20301.10

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@CyrusNajmabadi
Merge pull request dotnet#44713 from CyrusNajmabadi/missingNamespace
884fdff 
Fix OOP crashes due to inability to roundtrip error symbols.
@agocke agocke changed the base branch from master to features/records June 3, 2020 07:23
@agocke agocke closed this Jun 3, 2020
@agocke agocke reopened this Jun 3, 2020
@agocke agocke force-pushed the merge-to-records branch 3 times, most recently from 2d2ff66 to bf89fea Compare June 3, 2020 16:41
@agocke agocke force-pushed the merge-to-records branch from bf89fea to b3512ae Compare June 3, 2020 18:20
@agocke agocke closed this Jun 3, 2020
@agocke agocke reopened this Jun 3, 2020
@agocke agocke marked this pull request as ready for review June 3, 2020 22:30
@agocke agocke requested review from a team as code owners June 3, 2020 22:30
@agocke agocke requested a review from a team June 3, 2020 22:30
ghost
ghost approved these changes Jun 3, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@agocke agocke mentioned this pull request Jun 3, 2020
Merged
@ghost ghost merged commit cef3156 into dotnet:features/records Jun 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.