Skip to content

Only offer 'Use coalesce expression' in C#8 and above.#44798

Merged
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:featureVersion
Jun 2, 2020
Merged

Only offer 'Use coalesce expression' in C#8 and above.#44798
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:featureVersion

Conversation

@CyrusNajmabadi
Copy link
Contributor

Fixes #44793

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 6b3ce16 into dotnet:master Jun 2, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the featureVersion branch June 2, 2020 23:07
@sharwell
Copy link
Contributor

@CyrusNajmabadi Can you set the milestone for this (version and preview)? Milestones must be set manually for all pull requests where the auto-merge feature is used.

@CyrusNajmabadi
Copy link
Contributor Author

I odn't know what milestone this went into. How can I find out? Is there some sort of reverse mapping service? Can we make the auto-merge bot set this? Who would we contact about that? Thanks!

@RikkiGibson
Copy link
Member

It seems like this somehow slipped through the cracks, we're supposed to have an automation that adds everything to the Next milestone and things get moved to the correct milestone from there.

@sharwell
Copy link
Contributor

sharwell commented Sep 1, 2020

@RikkiGibson There was a long period of time where auto-merge PRs did not also get milestones automatically. The PR author needs to manually set the milestones for these PRs.

@sharwell sharwell added this to the 16.7.P4 milestone Sep 1, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDE0074 'Use compound assignment' should not be offered for pre-8.0 language versions

5 participants