Skip to content

Simplify PEPropertySymbol constructor#43990

Merged
jcouv merged 1 commit intodotnet:masterfrom
jcouv:simplify-peproperty
May 6, 2020
Merged

Simplify PEPropertySymbol constructor#43990
jcouv merged 1 commit intodotnet:masterfrom
jcouv:simplify-peproperty

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented May 5, 2020

Removing some dead code

@jcouv jcouv self-assigned this May 5, 2020
@jcouv jcouv marked this pull request as ready for review May 6, 2020 18:35
@jcouv jcouv requested a review from a team as a code owner May 6, 2020 18:35
@jcouv jcouv requested a review from AlekseyTs May 6, 2020 18:35
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcouv jcouv merged commit 9d1b407 into dotnet:master May 6, 2020
@ghost ghost added this to the Next milestone May 6, 2020
@jcouv jcouv deleted the simplify-peproperty branch May 6, 2020 19:39
333fred added a commit to 333fred/roslyn that referenced this pull request May 6, 2020
* upstream/master: (495 commits)
  Simplify PEPropertySymbol constructor (dotnet#43990)
  Remove duplicate calls to ThrowIfCancellationRequested
  Allow msbuild to pass properties and metadata as analyzerconfig: (dotnet#43617)
  Use a private exception type for error types encountered instead of ArgumentException.
  Remove unnecessary check
  Code review feedback
  Adding tests and expanding side effect cases
  Expose specific members of System.[U]IntPtr from native integer types (dotnet#43766)
  Remove trailing space from BoundDecisionDagNode
  Don't cache FileInfo instances.
  Add 16.7 Preview 1 to the publish data config
  Bump prerelease version for 16.7 preview 2
  Only run code style analyzers when nullable warnings are enabled
  Remove
  Code review feedback
  Lint
  Undo
  Fix regression in global:: qualified constant in a switch case. Fixes dotnet#43960
  Undo
  Simplify
  ...
@JoeRobich JoeRobich modified the milestones: Next, 16.7.P2 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants