Simplification and cleanup of our symbol index now that it is OOP.#43804
Merged
17 commits merged intodotnet:masterfrom May 2, 2020
Merged
Simplification and cleanup of our symbol index now that it is OOP.#4380417 commits merged intodotnet:masterfrom
17 commits merged intodotnet:masterfrom
Conversation
tmat
reviewed
May 1, 2020
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Collections.Concurrent; |
Member
There was a problem hiding this comment.
using [](start = 0, length = 5)
#nullable enable
tmat
reviewed
May 1, 2020
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Collections.Concurrent; |
Member
There was a problem hiding this comment.
using [](start = 0, length = 5)
#nullable enable
tmat
reviewed
May 1, 2020
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Collections.Generic; |
Member
There was a problem hiding this comment.
using [](start = 0, length = 5)
#nullable enable
ryzngard
approved these changes
May 2, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #43801. That should go in first.
this should be reviewed commit-by-commit.