Only precompute and cache indices in the OOP process.#43801
Merged
CyrusNajmabadi merged 12 commits intodotnet:masterfrom May 1, 2020
Merged
Only precompute and cache indices in the OOP process.#43801CyrusNajmabadi merged 12 commits intodotnet:masterfrom
CyrusNajmabadi merged 12 commits intodotnet:masterfrom
Conversation
tmat
reviewed
May 1, 2020
| return Task.CompletedTask; | ||
| } | ||
|
|
||
| if (!RemoteFeatureOptions.ShouldComputeIndex(document.Project.Solution.Workspace)) |
Member
There was a problem hiding this comment.
ShouldComputeIndex [](start = 42, length = 18)
Is this method still used elsewhere?
Contributor
Author
There was a problem hiding this comment.
let me check. i will remove if not!
tmat
reviewed
May 1, 2020
src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_FindReferences_Current.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 1, 2020
src/Workspaces/Core/Portable/FindSymbols/FindReferences/DependentTypeFinder_Remote.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to:
#43636 and #43771