Move dependent-type-finding operations out of process.#43636
Move dependent-type-finding operations out of process.#43636CyrusNajmabadi merged 19 commits intodotnet:masterfrom
Conversation
|
@jasonmalinowski This is ready for review now. |
| @@ -4,19 +4,58 @@ | |||
|
|
|||
There was a problem hiding this comment.
renaming the file made this show as two different files, so i'm going to rename later.
| @@ -174,7 +174,7 @@ private static async Task<ImmutableArray<INamedTypeSymbol>> DescendInheritanceTr | |||
| // We might miss a derived type in C if there's an intermediate derived type | |||
There was a problem hiding this comment.
the changes in this file are followup to PR feedback from previous PR.
| t => t.TypeKind == TypeKind.Class || | ||
| t.TypeKind == TypeKind.Struct || | ||
| t.TypeKind == TypeKind.Delegate || | ||
| t.TypeKind == TypeKind.Enum); |
There was a problem hiding this comment.
found by @jasonmalinowski when reviewing the the previous PR.
| Renamer_ResolveConflictsAsync = 388, | ||
|
|
||
| ChangeSignature_Data = 389, | ||
| ChangeSignature_Data = 400, |
There was a problem hiding this comment.
400 [](start = 31, length = 3)
Shouldn't this be immutable once shipped? This is used for telemetry, so changing the values would render counters that span multiple version useless.
There was a problem hiding this comment.
We haven't shipped any of these. These were all conflicts between having n prs trying to go through at the same time. I'm just trying to give these all some space as I keep needing to have to go back to features to add items and that means the numbers are all disconnected and the feature IDs are all scattered. This allows us to add ids really in a section in the future in a painless way
There was a problem hiding this comment.
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Collections.Immutable; |
There was a problem hiding this comment.
using [](start = 0, length = 5)
#nullable enable
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; |
There was a problem hiding this comment.
System [](start = 6, length = 6)
#nullable enable
| @@ -0,0 +1,68 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
There was a problem hiding this comment.
// [](start = 0, length = 2)
#nullable enable
Followup to #43622. That PR should be reviewed first.
This moves the searching portion of the dependent-type-finder OOP allowing s to do that expensive work without impacting the main VS process.