Introduce explicit downcast to VB .NET#43351
Merged
CyrusNajmabadi merged 55 commits intodotnet:masterfrom May 5, 2020
Merged
Conversation
ryzngard
reviewed
Apr 15, 2020
src/EditorFeatures/CSharpTest/Diagnostics/AddExplicitCast/AddExplicitCastTests_FixAllTests.cs
Show resolved
Hide resolved
ryzngard
reviewed
Apr 15, 2020
src/Features/Core/Portable/CodeFixes/AddExplicitCast/InheritanceDistanceComparer.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Apr 15, 2020
src/Features/Core/Portable/CodeFixes/AddExplicitCast/InheritanceDistanceComparer.cs
Outdated
Show resolved
Hide resolved
…ceDistanceComparer.cs Co-Authored-By: Andrew Hall <ryzngard@live.com>
ryzngard
reviewed
Apr 15, 2020
.../VisualBasic/Portable/CodeFixes/AddExplicitCast/VisualBasicAddExplicitCastCodeFixProvider.vb
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/Diagnostics/AddExplicitCast/AddExplicitCastTests.cs
Show resolved
Hide resolved
src/EditorFeatures/VisualBasicTest/Diagnostics/InsertMissingCast/InsertMissingCastTests.vb
Show resolved
Hide resolved
ryzngard
reviewed
Apr 15, 2020
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
About half through, need to move onto some other work for a bit. I'll try to finish up tonight.
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/CSharpAddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/CodeFixes/AddExplicitCast/AbstractAddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Looking now. |
CyrusNajmabadi
approved these changes
May 4, 2020
Contributor
|
@CyrusNajmabadi Good to close this #33533 ? |
Contributor
|
Yup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous C# version pr: #41371
Implement code fix for error code: BC30512/BC42016, BC30518/BC30159
Update: