Fix issues with 'Remove unnecessary cast'#42883
Merged
22 commits merged intodotnet:masterfrom Mar 30, 2020
Merged
Conversation
CyrusNajmabadi
commented
Mar 29, 2020
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Linq; |
Contributor
Author
There was a problem hiding this comment.
stale file. likely a merge conflict when we moved things to the shared layer.
sharwell
reviewed
Mar 30, 2020
| return false; | ||
|
|
||
| // Don't remove any explicit numeric casts. | ||
| // https://github.com/dotnet/roslyn/issues/2987 tracks improving on this conservative approach. |
Contributor
There was a problem hiding this comment.
❔ Comment still necessary?
Comment on lines
+161
to
+163
| if (castedExpressionNode.WalkDownParentheses().IsKind(SyntaxKind.DefaultLiteralExpression) && | ||
| !castType.Equals(outerType) && | ||
| outerType.IsNullable()) |
Contributor
There was a problem hiding this comment.
😕 It's hard to relate this condition to the one it tests for. I'll need to come back to it.
Contributor
Please update that issue to explain how this improvement was approached. |
sharwell
reviewed
Mar 30, 2020
Comment on lines
+450
to
+451
| // Switch expression's expression changed. Ensure it's the same type as before. If not, inference of | ||
| // the meaning of the patterns within can change. |
Contributor
There was a problem hiding this comment.
❔ Do we not need to check the patterns, like we do for switch statements?
Contributor
Author
There was a problem hiding this comment.
it's quite possble we need to for total correctness. i'm not certain at this point. going to leave it alone for now :)
…mplification/Simplifiers/CastSimplifier.cs Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
…mplification/Simplifiers/CastSimplifier.cs Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
…mplification/Simplifiers/CastSimplifier.cs Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
sharwell
approved these changes
Mar 30, 2020
| public int Compare(object x, object y) | ||
| { | ||
| return this.x.Compare(x, y); | ||
| return ((IComparer)this.x).Compare(x, y); |
Contributor
There was a problem hiding this comment.
📝 I'm OK with the approach taken in this pull request to put us back on a more conservative path, but we should file a follow-up issue to consider ways to improve this scenario in the future.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41433
Fixes #38599
Fixes #32491
Fixes #25021
Fixes #2987
Fixes #38347
Fixes #36631
Fixes #34326
Fixes #29726
Fixes #6309
Fixes #34873
Fixes #37953
Fixes #42657
Fixes #42108
This PR should be reviewed one commit at a time.