Conversation
src/ExpressionEvaluator/Core/Source/ResultProvider/ResultProvider.projitems
Outdated
Show resolved
Hide resolved
jasonmalinowski
left a comment
There was a problem hiding this comment.
@tmat We've validated that add/remove a file through Visual Studio doesn't end up adding explicit entries if the glob is still there? All for the change, but if the IDE flakes out we'll probably want to get any bugs filed, or at least email the team to warn them about those bugs.
|
awesome! |
|
@tmat This is actually turning out to be painful for working with shared project due to dotnet/project-system#6010. Moving a folder to shared project and then deleting one or more files is causing VS to remove the glob entry and replace it with explicit entries. This leads to build failure, and forces to undo the changes to projitems file, which forces the solution to be unloaded and reloaded.
|
|
@tmat VS is pretty much unusable due to lack of first class globing support in shared projects. Even for simple file moves between shared projects, the tooling is corrupting the projitems file and removing the glob entry, requiring undo to file changes and solution reload, and is going to be harder to track down for someone who doesn’t know about this issue. Would you be able to restore to prior non-globing state until project system adds this support? Note you will need to revert your PR and then manually add/remove the entries from PRs that went in after your change and relied on glob entries (I at least merged couple of PRs yesterday after your merge that would need this work). |
|
:( |
This reverts commit 423c52f.
Revert "Use globs in .projitems (#42517)"
Makes updating and merging updates of shared projects easier.