Do not report unused parameters for trivial throw-only methods#42408
Merged
9 commits merged intodotnet:masterfrom Mar 14, 2020
Merged
Do not report unused parameters for trivial throw-only methods#424089 commits merged intodotnet:masterfrom
9 commits merged intodotnet:masterfrom
Conversation
Therzok
reviewed
Mar 14, 2020
| if (!(firstBlock is IBlockOperation block)) | ||
| return false; | ||
|
|
||
| var explicitOperations = block.Operations.WhereAsArray(op => !op.IsImplicit); |
Contributor
There was a problem hiding this comment.
Wouldn't this create a copy of almost every operation block array? Seems expensive for a filter check.
Contributor
Author
There was a problem hiding this comment.
That's a great point. I'll tweak.
mavasani
approved these changes
Mar 14, 2020
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Dec 24, 2021
Fixes dotnet#56317 dotnet#42408 handled bailing out reporting unused params for methods that only have a throw operation in its body. It missed a case where the throw might be wrapped within a conversion wrapped within a return operation, which happens when the method returns a non-void type.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41236