Conversation
- This is the first step to removing IVT to Razor assemblies from core Roslyn assemblies. Once Razor is able to consume these changes and move to the new APIs we can entirely remove the IVTs from Roslyn assemblies. - Brought Razor's `IDynamicFileInfoProvider` implementation over to the ExternalAccess.Razor package and built a new concept (`IRazorDocumentContainer`) that allows Razor to pass it just enough information about the document to Roslyn for it to "do the right thing". dotnet/aspnetcore#19551
c3376c2 to
0224b31
Compare
tmat
reviewed
Mar 9, 2020
src/Tools/ExternalAccess/Razor/DocumentServiceProviderFactory.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 9, 2020
tmat
reviewed
Mar 9, 2020
src/Tools/ExternalAccess/Razor/DelegatingRazorDocumentExcerptService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 9, 2020
src/Tools/ExternalAccess/Razor/DelegatingRazorSpanMappingService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 9, 2020
src/Tools/ExternalAccess/Razor/DefaultDocumentServiceProviderFactory.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 9, 2020
tmat
reviewed
Mar 9, 2020
src/Tools/ExternalAccess/Razor/IRazorIDocumentExcerptService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 9, 2020
tmat
reviewed
Mar 9, 2020
tmat
reviewed
Mar 9, 2020
Author
|
🆙 📅 Refactored Razor.ExternalAccess to leave more logic in Razor.
|
- Now `IDynamicFileInfoProvider` is shimmed and the core-logic exists in the Razor repo. - Added the ExternalAccess.Razor piece to the Roslyn deployment to ensure our `IDynamicFileInfoProvider` wrapper can be found by MEF components. In the case that the Razor workload is not available we allow a `null` Razor dynamic file implementation. - Updated the ExternalAccess.Razor project to be netstandard2.0 instead of net472 so it vibes better with the Razor repo. dotnet/aspnetcore#19551
29494fe to
a2ca201
Compare
tmat
reviewed
Mar 13, 2020
src/Tools/ExternalAccess/Razor/RazorDynamicFileInfoProviderWrapper.cs
Outdated
Show resolved
Hide resolved
…e DynamicFileInfoProvider not load Razor assemblies in non-Razor scenarios.
Author
|
🆙 📅 Turn nullable reference types on for ExternalAccess.Razor and make the DynamicFileInfoProvider not load Razor assemblies in non-Razor scenarios. |
tmat
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDynamicFileInfoProviderimplementation over to the ExternalAccess.Razor package and built a new concept (IRazorDocumentContainer) that allows Razor to pass it just enough information about the document to Roslyn for it to "do the right thing".dotnet/aspnetcore#19551
@tmat this takes care of all of the IVT dependent Razor APIs 🎁
Razor PR to react to the changes (WIP): dotnet/razor#1655