[WIP] Move to Roslyn's ExternalAccess.Razor assembly.#1655
Closed
NTaylorMullen wants to merge 1 commit intomasterfrom
Closed
[WIP] Move to Roslyn's ExternalAccess.Razor assembly.#1655NTaylorMullen wants to merge 1 commit intomasterfrom
NTaylorMullen wants to merge 1 commit intomasterfrom
Conversation
dougbu
reviewed
Mar 5, 2020
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/Microsoft.VisualStudio.Editor.Razor.csproj
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/Microsoft.VisualStudio.Editor.Razor.csproj
Outdated
Show resolved
Hide resolved
Author
|
Note for others; This should be a draft PR 😆 |
e2d7b6e to
027eb85
Compare
027eb85 to
ef75a87
Compare
ef75a87 to
f23f1b9
Compare
This was referenced Apr 10, 2020
Author
|
Closing in favor of another PR. Will have one out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tmat / @sharwell this is the prepped reaction for once we have packages containing our shim bits from Roslyn. Of course it's in a super WIP state but it'll give you some of an idea as to what we'll be doing to consume the changes.