Port ConvertSwitchStatementToExpression analyzer/fixer/tests to share…#42171
Merged
mavasani merged 1 commit intodotnet:masterfrom Mar 5, 2020
Merged
Conversation
…d layer Straightforward file and resource moves to shared layer.
mavasani
commented
Mar 4, 2020
| @@ -85,9 +89,6 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context) | |||
| .Add(Constants.ShouldRemoveNextStatementKey, shouldRemoveNextStatement.ToString(CultureInfo.InvariantCulture)))); | |||
| } | |||
|
|
|||
| public override bool OpenFileOnly(OptionSet options) | |||
Contributor
Author
There was a problem hiding this comment.
Redundant override as the base implementation also returns false.
...s/CSharp/Tests/ConvertSwitchStatementToExpression/ConvertSwitchStatementToExpressionTests.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 4, 2020
alrz
reviewed
Mar 19, 2020
| <ItemGroup> | ||
| <Compile Include="$(MSBuildThisFileDirectory)ConvertSwitchStatementToExpression\ConvertSwitchStatementToExpressionConstants.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)ConvertSwitchStatementToExpression\ConvertSwitchStatementToExpressionDiagnosticAnalyzer.Analyzer.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)ConvertSwitchStatementToExpression\ConvertSwitchStatementToExpressionDiagnosticAnalyzer.cs" /> |
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d layer
Straightforward file and resource moves to shared layer. Recommend reviewing with xlf file filter applied: Review link