Skip to content

DiagnosticIncrementalAnalyzer refactoring#39956

Merged
tmat merged 23 commits intodotnet:masterfrom
tmat:WorkspaceDiagnostics
Nov 26, 2019
Merged

DiagnosticIncrementalAnalyzer refactoring#39956
tmat merged 23 commits intodotnet:masterfrom
tmat:WorkspaceDiagnostics

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Nov 22, 2019

Refactors IncrementalDiagnosticAnalyzer to enable nullability checks, simplify and make code more readable.

@tmat tmat force-pushed the WorkspaceDiagnostics branch 6 times, most recently from 222e6a8 to 568df59 Compare November 24, 2019 22:57
@tmat tmat force-pushed the WorkspaceDiagnostics branch from 568df59 to d3e30f6 Compare November 24, 2019 23:00
@tmat tmat changed the title Workspace diagnostics DiagnosticIncrementalAnalyzer refactoring Nov 25, 2019
@tmat tmat marked this pull request as ready for review November 25, 2019 18:16
@tmat tmat requested a review from a team as a code owner November 25, 2019 18:16
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Nov 25, 2019

@mavasani Could you take a look please?

@tmat tmat force-pushed the WorkspaceDiagnostics branch from 5a47af7 to 7033458 Compare November 25, 2019 18:22
Copy link
Copy Markdown
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. @heejaechang might want to take a look to confirm if none of the critical perf optimizations that he might have added got removed.

Comment thread src/Features/Core/Portable/Diagnostics/AnalyzerHelper.cs Outdated
Comment thread src/Features/Core/Portable/Diagnostics/AnalyzerHelper.cs Outdated
Comment thread src/Features/Core/Portable/Diagnostics/AnalyzerHelper.cs Outdated
Comment thread src/Features/Core/Portable/Diagnostics/AnalyzerHelper.cs Outdated
Comment thread src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService.cs
Comment thread src/Features/Core/Portable/Diagnostics/HostAnalyzerManager.cs
Comment thread src/Workspaces/Core/Portable/Diagnostics/DiagnosticAnalysisResult.cs Outdated
Comment thread src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs Outdated
Comment thread src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs Outdated
Comment thread src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs
Comment thread src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs Outdated
tmat and others added 5 commits November 26, 2019 13:27
…ementalAnalyzer_GetDiagnostics.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@tmat tmat merged commit 44fccc1 into dotnet:master Nov 26, 2019
@tmat tmat deleted the WorkspaceDiagnostics branch November 26, 2019 23:32
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 2, 2019
…ointers

* dotnet/master: (197 commits)
  Update dependencies from https://github.com/dotnet/arcade build 20191201.1 (dotnet#40084)
  Update list of C# Next features and reviewers (dotnet#39987)
  Update dependencies from https://github.com/dotnet/arcade build 20191130.1 (dotnet#40075)
  [master] Update dependencies from dotnet/arcade (dotnet#40065)
  Update dependencies from https://github.com/dotnet/arcade build 20191127.4 (dotnet#40057)
  Added more tests & fixed minor bug
  Deterministic ordering + added tests back
  Update dependencies from https://github.com/dotnet/arcade build 20191126.2 (dotnet#40036)
  removed a test due to random order generation
  Always restore when running a bootstrap build (dotnet#40025)
  fixed integration test capitalization for extract method and extract interface
  Fix tests pt2
  DiagnosticIncrementalAnalyzer refactoring (dotnet#39956)
  Persistence is always available in OOP
  Update src/Workspaces/Core/Portable/SolutionSize/SolutionSizeTracker.cs
  Fixed tests
  Move reporting of iterator diagnostics to avoid race condition (dotnet#39990)
  Update dependencies from https://github.com/dotnet/arcade build 20191125.7 (dotnet#40020)
  Fix NGEN priority of csc.exe, vbc.exe, csi.exe (dotnet#40016)
  Accidentally deleted something
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants