Rely on PDB document table for identification of design-time-only source files#39295
Merged
tmat merged 1 commit intodotnet:masterfrom Oct 15, 2019
Merged
Rely on PDB document table for identification of design-time-only source files#39295tmat merged 1 commit intodotnet:masterfrom
tmat merged 1 commit intodotnet:masterfrom
Conversation
Member
Author
|
PTAL @ivanbasov |
ivanbasov
approved these changes
Oct 15, 2019
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Nov 15, 2019
…ebugging session starts Previous change dotnet#39295 allowed us to rely on PDB source file checksums when distinguishing between design-time-only documents that should be ignored when applying changes and documents whose changes must be applied to the debuggee. The change did not handle the case when the PDB isn't loaded yet when this check is being performed. This bug resulted in changes not being applied correctly and documents getting out-of-sync in scenarios where the modules were not loaded to the debuggee fast enough. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1013242
tmat
added a commit
that referenced
this pull request
Nov 18, 2019
#39836) * EnC: Fix document out-of-sync checks when module is not loaded when debugging session starts Previous change #39295 allowed us to rely on PDB source file checksums when distinguishing between design-time-only documents that should be ignored when applying changes and documents whose changes must be applied to the debuggee. The change did not handle the case when the PDB isn't loaded yet when this check is being performed. This bug resulted in changes not being applied correctly and documents getting out-of-sync in scenarios where the modules were not loaded to the debuggee fast enough. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1013242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use document list in PDB as the definitive indicator of whether a source file is design-time-only or not. This is now possible due to #39136.
Fixes #39271.
Fixes ADO 899910: Pop up a "Edit and Continue" dialog without ENC about C# uwp app