Ensure we have stack spilling support for the recently-added expression node BoundReadOnlySpanFromArray#37057
Merged
Merged
Conversation
…on node `BoundReadOnlySpanFromArray` Fixes dotnet#36856
RikkiGibson
approved these changes
Jul 8, 2019
jcouv
reviewed
Jul 9, 2019
| return UpdateExpression(builder, node.Update(node.OperatorKind, operand, node.ConstantValueOpt, node.MethodOpt, node.ResultKind, node.Type)); | ||
| } | ||
|
|
||
| public override BoundNode VisitReadOnlySpanFromArray(BoundReadOnlySpanFromArray node) |
Member
There was a problem hiding this comment.
VisitReadOnlySpanFromArray [](start = 34, length = 26)
not related to this PR: I wonder if there is a systematic way we can catch those situations (all the walkers/rewriters to consider when adding new bound nodes)... Maybe an analyzer could force us to write those methods, if only to call the base?
333fred
reviewed
Jul 9, 2019
| } | ||
|
|
||
| [Fact, WorkItem(36856, "https://github.com/dotnet/roslyn/issues/36856")] | ||
| public void Crash36856() |
Member
There was a problem hiding this comment.
Crash36856 [](start = 20, length = 10)
Consider using a name that is actually descriptive, without having to visit the linked bug.
333fred
approved these changes
Jul 9, 2019
333fred
left a comment
Member
There was a problem hiding this comment.
LGTM other than test name comment.
canton7
added a commit
to canton7/roslyn
that referenced
this pull request
Jul 9, 2019
…ncat-order * upstream/master: (1532 commits) Ensure we have stack spilling support for the recently-added expression node `BoundReadOnlySpanFromArray` (dotnet#37057) Review feedback Avoid generating or emitting NullablePublicOnlyAttribute when no other nullable attributes are emitted (dotnet#37019) Respond to more feedback Fixes from feedback Call `.WithoutNullability()` less Fix ngen for assets from nuget Make NullableWalker aware of calls to Interlocked.CompareExchange fix error Update AnonymousObjectCreation implementation to be more robust to errors by using MemberIndexOpt. Address minor PR comments. Add support to ngen assets included from nuget package Modified node removal to keep original leading trivia Fix Solution.WithDocumentFilePath not updating the file path of the tree Improve docs. PR Feedback cleanup. Use pattern-matching in MetadataWriter for readability and possibly performance. (dotnet#36219) Renamed helpers in SyntaxFactsService. More RefactoringHelpers tests (mostly for extraction). Add general tests for RefactoringHelpersService. Optimize flow analysis assembly ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36856
@dotnet/roslyn-compiler May I please have a couple of reviews of this tiny bug fix?