EnC emit tests for C# 8.0 patterns#37025
Merged
gafter merged 6 commits intodotnet:masterfrom Jul 11, 2019
Merged
Conversation
ivanbasov
commented
Jul 5, 2019
gafter
suggested changes
Jul 8, 2019
Member
gafter
left a comment
There was a problem hiding this comment.
Please fix the problem exposed by the failing test.
Contributor
|
@ivanbasov This appears to have broken builds completely. All my builds are failing with: Tagging @jasonmalinowski @dotnet/roslyn-infrastructure See https://dev.azure.com/dnceng/public/_build/results?buildId=261072&view=logs for example. |
Member
|
Likely bad merge. Fixing. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 11, 2019
* dotnet/master: Fix master build (dotnet#37163) Add error for multiple null suppressions (dotnet#37139) Check for uninitialized non-nullable field-like events (dotnet#37073) EnC emit tests for C# 8.0 patterns (dotnet#37025) Update dependencies from https://github.com/dotnet/arcade build 20190710.8 Update dependencies from https://github.com/dotnet/arcade build 20190709.6 [master] Update dependencies from dotnet/arcade (dotnet#37001) Add annotations to HostWorkspaceServices.cs and HostLanguageServices.cs Add nullable annotations to members in Solution.cs, SolutionInfo.cs, and SolutionState.cs Annotate Contract.cs Add nullable annotations and fixes to Workspace.cs Fix typo in documentation comment for Workspace.Dispose Check in copy of NullableAttributes.cs copied from coreclr Use switch expressions to simplify GetAccessibilityAndModifiers
Member
|
@CyrusNajmabadi The build has been fixed up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.