Update ILAsm and ILDasm version to match expected SDK version#36154
Merged
Update ILAsm and ILDasm version to match expected SDK version#36154
Conversation
jasonmalinowski
approved these changes
Jun 4, 2019
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Should we use a common property shared by all so this doesn't happen again?
Member
Author
@jasonmalinowski The version of ILAsm and ILDasm expected is found by
|
Member
|
@JoeRobich That seems...roundabout. Wonder what other options we have? Let's merge this of course if something is broken but wondering how we can decouple things to be less tricky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @AlekseyTs, #36042 should have also bumped the ILAsm and ILDasm version numbers.