Add EditorConfig feature flag#36042
Conversation
eng/Versions.props
Outdated
There was a problem hiding this comment.
This version of the toolset has a workaround for GetPathsOfAllDirectoriesAbove
There was a problem hiding this comment.
Any reason this isn't flowing from Arcade (which might encourage regular updates/making those updates automated)?
There was a problem hiding this comment.
At times we need a newer version than what Arcade offers just do to bootstrapping. In general we should be flowing from Arcade but there are specific points where we need to override it.
In reply to: 289079090 [](ancestors = 289079090)
global.json
Outdated
There was a problem hiding this comment.
This version of .NET SDK has a MSBuild fix for GetPathsOfAllDirectoriesAbove
There was a problem hiding this comment.
Please update the contributing docs to link to the new SDK version and installer link.
In reply to: 288795365 [](ancestors = 288795365)
|
Any reason to not have arcade auto-flow this dependency @tmat |
jasonmalinowski
left a comment
There was a problem hiding this comment.
I can't say if this won't break something, but looks OK?
There was a problem hiding this comment.
Do make sure to email the team when this goes in, because otherwise people won't be aware of it.
There was a problem hiding this comment.
Can you guys please post this information somewhere, or ping the community? Ths stuff just ends up breaking external people with zero information as to what's going on. Tagging @jinujoseph as well on this.
60ec8ef to
f01af10
Compare
| <MicrosoftNetCompilersToolsetVersion>3.1.0-beta1-19164-01</MicrosoftNetCompilersToolsetVersion> | ||
| <MicrosoftNetCompilersToolsetVersion>3.2.0-beta2-19275-07</MicrosoftNetCompilersToolsetVersion> | ||
| <MicrosoftNetCoreAnalyzersVersion>$(RoslynDiagnosticsNugetPackageVersion)</MicrosoftNetCoreAnalyzersVersion> | ||
| <MicrosoftNetCoreILAsmVersion>3.0.0-preview6-27706-71</MicrosoftNetCoreILAsmVersion> |
There was a problem hiding this comment.
3.0.0-preview6-27706-71 [](start = 34, length = 23)
Don't we need to update this version as well?
| <MicrosoftNetCompilersToolsetVersion>3.2.0-beta2-19275-07</MicrosoftNetCompilersToolsetVersion> | ||
| <MicrosoftNetCoreAnalyzersVersion>$(RoslynDiagnosticsNugetPackageVersion)</MicrosoftNetCoreAnalyzersVersion> | ||
| <MicrosoftNetCoreILAsmVersion>3.0.0-preview6-27706-71</MicrosoftNetCoreILAsmVersion> | ||
| <MicrosoftNetCoreILDasmVersion>3.0.0-preview6-27706-71</MicrosoftNetCoreILDasmVersion> |
There was a problem hiding this comment.
3.0.0-preview6-27706-71 [](start = 35, length = 23)
Don't we need to update this version as well?
No description provided.