…sible, and add a caching strategy to the snapshotter to reduce garbage creation for every node. Addressed minor PR feedback items as well.

…ed things, and turned it into an immutable structure backed by a builder used by nullable walker.

…r.cs

…of the SnapshotManager.Builder implementation, and updated some documentation.

…evert some changes in this PR to original state.

(DisposableFieldsShouldBeDisposed)

We will now flag disposable creations in methods that do not escape the
method body (return value, out/ref params, assign to field/property, add
to collection, etc.). Additionally, we also flag disposable fields of
disposable types that are not disposed in the type's Dispose method.
Ported analyzers share the core dataflow analysis computation with the
analyzers in the roslyn-analyzers repo
(Microsoft.CodeAnalysis.FlowAnalysis.Utilities). This PR does not add
any code fixes. We already have a code
refactoring that offers wrapping a disposable creation within a using
statement. I am hoping to extend that to handle more cases and also
possibly convert it to a code fix in follow-up PR(s).

… assembly load lazy and revert reference add to the FlowAnalysis assembly in Workspaces (only referenced in Features now).

…rs#2501)

Additionally, we do not mark the package reference to in Features.csproj as PrivateAsset as this leads to the assembly not getting included in the Features NuGet package and causes Omnisharp's analyzer execution to throw missing dependency assembly load errors.
Also update ExpectedDependency in DevDivInsertionFiles.csproj

…icAnalyzer

…eview2

Port DisposeAnalyzers to release/dev16.2-preview2

…for LazyNoneOperation

…-to-master

Merge release/dev16.2-preview2 to master

* Cleanup style

* Remove BlueSquiggleForBuildDiagnostic

* TableDataSource refactoring

* Remove DiagnosticData.Workspace

* Fix workspace reference

* Simplify GetTrackingPoints

* Simplify deduplication

* EqualsModuloLocation

* Simplify navigate to

* Specialize table item

* Fix assert

* Feedback

* Dedup TryNavigateTo

* Couple of renames

Don't read the same property twice in pattern matching when accessed through the same underlying object, but references of different types.
Fixes #34933

Specify the version number in pieces so we can generate the assembly version using just the major and minor version numbers.

Don't capture BoundNode when creating a LazyNoneOperation

Add initial checkpointing to the nullable walker.

Generate assembly version without using the patch version.