Skip to content

Generate assembly version without using the patch version.#36134

Merged
JoeRobich merged 1 commit intomasterfrom
generate-assembly-version
Jun 3, 2019
Merged

Generate assembly version without using the patch version.#36134
JoeRobich merged 1 commit intomasterfrom
generate-assembly-version

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

Specify the version number in pieces so we can generate the assembly version using just the major and minor version numbers.

Specify the version number in pieces so we can generate the assembly version using just the major and minor version numbers.
@JoeRobich
Copy link
Copy Markdown
Member Author

@jasonmalinowski @tmat @jaredpar Is this a sane way to avoid breaking assembly redirects due to incrementing the patch version?

@tmat
Copy link
Copy Markdown
Member

tmat commented Jun 3, 2019

What issue are we trying to address?

@JoeRobich
Copy link
Copy Markdown
Member Author

What issue are we trying to address?

@tmat Updating the VersionPrefix so that nuget packages can have a patch number without breaking AssemblyVersion redirects.

@tmat
Copy link
Copy Markdown
Member

tmat commented Jun 3, 2019

But why would we need to do that?

@JoeRobich
Copy link
Copy Markdown
Member Author

But why would we need to do that?

@tmat The recommendation from the Version.props AssemblyVersion comment was to hardcode the AssemblyVersion when performing servicing to avoid breaking redirects. The hope was to avoid having to do that in the future, because you then have to ensure that change doesn't flow forward to other branches.

@tmat
Copy link
Copy Markdown
Member

tmat commented Jun 3, 2019

I see. Makes sense.

@JoeRobich JoeRobich marked this pull request as ready for review June 3, 2019 22:37
Copy link
Copy Markdown
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as @jasonmalinowski approves.

Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I approve as long as @tmat approves. Recursion! (This looks fine.)

@JoeRobich JoeRobich merged commit 699318c into master Jun 3, 2019
@JoeRobich JoeRobich deleted the generate-assembly-version branch June 4, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants