Merged
Conversation
…adata attribute values (dotnet#34909) Fixes dotnet#33952
jcouv
reviewed
May 7, 2019
Member
Author
|
Planning on merging this after the dev16.2 preview1 snap on May 8th |
Member
|
@RikkiGibson This PR seems ready to merge, if it is still relevant. Can it be merged or closed? |
Member
Author
|
It's definitely relevant. I was just waiting until things calmed down with VS insertions because there's a small risk that this re-introduces a build failure on the VS side. Since we just inserted to all VS branches (yay!) I will go ahead and merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #34909. Meant to exercise #35217.
cc @gafter @jaredpar
We believe we've addressed the problem that this change produces via #35311 and #35373.