Make bootstrap 32 bit in 32 bit CI#35217
Merged
jaredpar merged 1 commit intodotnet:masterfrom Apr 24, 2019
Merged
Conversation
This changes our bootstrap compiler to run as a 32 bit process in the 32 bit CI runs. The intent of this runs is to validate we can function on 32 bit systems and that should extend to the compiler as well. This can help us identify the rare cases where we emit code that doesn't perform well on the 32 bit JIT, or just outright crashes.
Member
Author
|
@dotnet/roslyn-infrastructure for review. |
333fred
approved these changes
Apr 24, 2019
Member
|
I'm wondering if we cherry-pick e922628 into master now, will we start getting a build error? |
Member
Author
|
@RikkiGibson yes we should definitely do that. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes our bootstrap compiler to run as a 32 bit process in the 32
bit CI runs. The intent of this runs is to validate we can function on
32 bit systems and that should extend to the compiler as well.
This can help us identify the rare cases where we emit code that doesn't
perform well on the 32 bit JIT, or just outright crashes.