Use Microsoft.SymbolUploader build task for symbol publishing#29247
Use Microsoft.SymbolUploader build task for symbol publishing#29247
Conversation
| /p:PublishStableVersions=false | ||
| /p:VersionStampToPublish=prerelease | ||
| /p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat) | ||
| /p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat) |
There was a problem hiding this comment.
I have linked the variable group that defines these variables with Roslyn-Signed build definition.
|
Do repo-toolset repos get this for free? Also tagging @brettfo for F# builds. |
Yes. They have been using this task for a while. |
|
Of course, the repos need to be on the latest version of the toolset and have their YAML definition updated. |
|
test windows_debug_vs-integration_prtest please |
|
test ubuntu_16_debug_prtest please |
1 similar comment
|
test ubuntu_16_debug_prtest please |
|
@jaredpar @jasonmalinowski @dotnet/roslyn-infrastructure PTAL. |
| <PackageReference Include="Microsoft.NETCore.Platforms" Version="$(MicrosoftNETCorePlatformsVersion)" ExcludeAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.Build.Tasks.Feed" Version="$(MicrosoftDotNetBuildTasksFeedVersion)" ExcludeAssets="all" /> | ||
| <PackageReference Include="Microsoft.SymbolUploader.Build.Task" Version="$(MicrosoftSymbolUploaderBuildTaskVersion)" ExcludeAssets="all" /> | ||
| <PackageReference Include="Microsoft.Net.RoslynDiagnostics" Version="$(MicrosoftNetRoslynDiagnosticsVersion)" ExcludeAssets="all" /> |
There was a problem hiding this comment.
Why did this second reference need to get added for this change?
There was a problem hiding this comment.
Looks like a bad merge. Will remove.
|
Does this significantly alter our build times or is it mostly neutral? |
|
I'ts 20 minutes faster. The difference is in Drop Publishing - we don't publish the symbols to a drop anymore. |
|
test this please |
…atures/compiler * dotnet/features/compiler: (183 commits) Document dotnet#13686 (dotnet#29416) Fix xml doc-comment resolution warnings PR feedback Add a perf benchmark for the compiler Emit phase (dotnet#29323) PR feedback Add documentation for the ProduceOnlyReferenceAssembly msbuild option to the refout docs (dotnet#29404) PR feedback Address PR feedback Expose refonly as an msbuild property (dotnet#29352) Add refactoring to convert foreach loop into linq invocations (Select, SelectMany and Where invocations) disable bad test Fix build error Restore the machinery for enabling language features by feature flags Assert message should sort diagnostics when possible (dotnet#29151) Update unix contributing docs Added Newtonsoft.Json to exclusion list Fix generation of compiler binding redirects (dotnet#29331) fixing hintspan size when Sub has attributes (dotnet#29115) Use Microsoft.SymbolUploader build task for symbol publishing (dotnet#29247) Remove default handling for bound nodes in (CS/VB)OperstionFactory.CreateInternal. (dotnet#29258) ...
Replaces symbol publishing VSTS tasks with SymbolUploader msbuild task for publishing symbols to symbol servers. This task is used by .NET and Arcade repositories for publishing symbols. It supports publishing both Portable and Windows PDBs, automatically archives all symbols (explicit archiving is not needed anymore) and doesn't suffer from MAX_PATH issues.
Signed build from SymbolUploader branch that successfully publishes symbols during
Vsbuildstep:https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=1942163&_a=summary&view=logs