Fix our Compiler NuGet dependency list#26762
Merged
jaredpar merged 13 commits intodotnet:masterfrom May 15, 2018
Merged
Conversation
400bf0b to
da11db6
Compare
Member
Author
|
Example of the output when the NuGet and SWR files are incorrect https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_build_correctness_prtest/13639/console |
jaredpar
commented
May 11, 2018
build/scripts/cibuild.cmd
Outdated
Member
Author
There was a problem hiding this comment.
This has to be kept until this PR is merged because the current state of netci.groovy depends on it. Once this is merged I will immediately follow up with a PR to delete this as it won't be needed anymore.
jaredpar
commented
May 11, 2018
Member
Author
There was a problem hiding this comment.
These DLLs are no longer deployed due to the change to MSBuildTask.csproj hence these attributes aren't needed anymore. If left the project will actually fail to compile.
Member
Author
|
CC @dotnet/roslyn-infrastructure for review |
The basic validation of our NuPkg and SWR files is implemented. There are sill some hacks on how these files are found (hard coded paths, etc ...) that need to be cleaned up. The basic checks though are in place.
Need to restructure our CI so that we can call build.ps1 from our test-build-correctness leg not the other way around. This is necessary as we now examine many other artifacts including NuGet packages.
This updates our NuSpec and SWR files to be compliant with the analysis we are now running over them.
The runtimes directory needs to be checked in addition to the root directory. This has the same set of problems with deployed dependencies.
jaredpar
added a commit
to jaredpar/roslyn
that referenced
this pull request
May 15, 2018
This is cleaning up some code needed to bootstrap groovy changes in an earlier PR: dotnet#26762
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses two problems:
One difference you will see after this change is there are more DLLs in our compiler toolset package, several of which are demonstrably unneeded. Part of the reason we've gotten into this state is we keep trying to outsmart our tooling here and only include DLLs we know are needed. This has proved to be extremely fragile. Instead the decision was made to simply take the dependencies listed in our build output directories.
I raised the point about the unnecessary DLLs being included in the output with the the SDK team. At this time the behavior is by design and there are no plans to change it.
Fixes: #26709