Merge dev15.7.x into dev15.7.x-vs-deps#26363
Merged
jasonmalinowski merged 8 commits intodev15.7.x-vs-depsfrom Apr 24, 2018
Merged
Merge dev15.7.x into dev15.7.x-vs-deps#26363jasonmalinowski merged 8 commits intodev15.7.x-vs-depsfrom
jasonmalinowski merged 8 commits intodev15.7.x-vs-depsfrom
Conversation
This change also ensures the projection buffers created in Visual Studio have the ITextBufferCloneService added to their property bag. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/604150
When generating a pinning temp for fixed statements on fixed buffers, the type for the pinning temp is ref to the type of the fixed field. However, in our lowering the type of a fixed buffer field is a pointer type, while what we actually want for the pinning temp is a ref to the underlying type. This change fixes that scenario. Fixes #26335
…ed.Core.targets (#26298)
Use ITextBufferCloneService if available in AsText
…serts to allow pointer to managed ref assignment for fixed-size buffers
Fix bad codegen for fixed buffer access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just flowing code to final branch.