Fix path to Microsoft.Build.Tasks.CodeAnalysis.dll in Microsoft.Managed.Core.targets#26298
Merged
tmat merged 1 commit intodotnet:dev15.7.xfrom Apr 24, 2018
Merged
Fix path to Microsoft.Build.Tasks.CodeAnalysis.dll in Microsoft.Managed.Core.targets#26298tmat merged 1 commit intodotnet:dev15.7.xfrom
tmat merged 1 commit intodotnet:dev15.7.xfrom
Conversation
Member
Author
|
@dotnet/roslyn-compiler Please review. |
agocke
reviewed
Apr 20, 2018
| <!-- | ||
| Common targets for managed compilers. | ||
| --> | ||
| <UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.MapSourceRoots" AssemblyFile="$(RoslynTargetsPath)\Microsoft.Build.Tasks.CodeAnalysis.dll" Condition="'$(MSBuildAssemblyVersion)' != ''" /> |
Member
There was a problem hiding this comment.
What's the stuff about MSBuildAssemblyVersion?
Contributor
There was a problem hiding this comment.
Good question I think that was also copied from https://github.com/Microsoft/msbuild/blob/master/src/Tasks/Microsoft.Common.tasks
Member
Author
There was a problem hiding this comment.
Yes, I copied it. I think it's only for backward compat so not necessary for new tasks.
Member
There was a problem hiding this comment.
Yeah, it can be safely dropped. I don't think we even need it on our side any more.
nguerrera
approved these changes
Apr 20, 2018
rainersigwald
approved these changes
Apr 21, 2018
agocke
approved these changes
Apr 21, 2018
jaredpar
approved these changes
Apr 21, 2018
Contributor
|
approved to merge via link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
Use Microsoft.NetCore.Compilers package in a project that is built by a .NET CLI that has different version of the C# compiler than the one in the package.
Bugs this fixes
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/604343
Workarounds, if any
None
Risk
Low
Performance impact
None
Is this a regression from a previous update?
Root cause analysis
Test was testing incorrect behavior.
How was the bug found?
Dogfooding
Test documentation updated?