Allow an embedded language to participate in document highlighting.#26075
Merged
jmarolf merged 2 commits intodotnet:features/embeddedRegexfrom Apr 11, 2018
Merged
Conversation
Contributor
Author
Contributor
Author
Contributor
|
This is much simpler. What is our strategy for tests here? Is that going to be resolved in a different PR? |
Contributor
Author
|
Yes. All of these are tested in their respective "JSON ide features" and "Regex IDE features" PRs. Those are the PRs that actually add the impls for those interfaces, so those are the best PRs to actually validate that they're doing the right thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't part of the previous embedded-language-services PR because that PR just contained the features necessary for embedded-json. Embedded-json doesn't have a need (afaict) for 'document highlights', whereas embedded-regex does.
Note: this should be reviewed after #26074 goes in.