Skip to content

Merging latest changes into features/embeddedRegex#26074

Merged
jmarolf merged 397 commits intodotnet:features/embeddedRegexfrom
CyrusNajmabadi:features/embeddedRegex
Apr 10, 2018
Merged

Merging latest changes into features/embeddedRegex#26074
jmarolf merged 397 commits intodotnet:features/embeddedRegexfrom
CyrusNajmabadi:features/embeddedRegex

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

This includes the new embedded-language-services changes that just went into features/embeddedJson.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 10, 2018 19:13
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

CyrusNajmabadi commented Apr 10, 2018

@jcouv @jmarolf @dotnet/roslyn-ide The same code that just went into features/embeddedJson. This is the system that allows an embedded language to export the right language services so that they light up automatically, without needing the actual features to know about this specific new language.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@jmarolf Safe merge-only PR for features/embeddedRegex (exact same as the one that went into features/embeddedJson).

@jmarolf jmarolf merged commit 7021e9b into dotnet:features/embeddedRegex Apr 10, 2018
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

Thanks!

@CyrusNajmabadi CyrusNajmabadi deleted the features/embeddedRegex branch April 10, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants