added more logging for completion to track some test failures where c…#25801
Merged
heejaechang merged 1 commit intodotnet:dev15.7.xfrom Mar 30, 2018
Merged
added more logging for completion to track some test failures where c…#25801heejaechang merged 1 commit intodotnet:dev15.7.xfrom
heejaechang merged 1 commit intodotnet:dev15.7.xfrom
Conversation
…ompletion doesn't show up when it should have. all these logging is No-op without logging enabled. and they are not enabled in product. only in test.
| { | ||
| AssertIsForeground(); | ||
|
|
||
| Logger.Log(FunctionId.Completion_ExecuteCommand_TypeChar, a => a.TypedChar.ToString(), args); |
Member
There was a problem hiding this comment.
@olegtk: does this exist in the core editor? If not, can it be? 😄
Contributor
There was a problem hiding this comment.
do you mean the Logger? No, but it would be awesome to have. Please file a bug.
Contributor
Author
Contributor
Author
|
retest windows_debug_unit64_prtest please |
Contributor
Author
|
ping? @dpoeschl @jinujoseph can you take a look? |
jinujoseph
approved these changes
Mar 30, 2018
Contributor
Author
|
@Pilchie can I get approval for 15.7? |
dpoeschl
approved these changes
Mar 30, 2018
Pilchie
approved these changes
Mar 30, 2018
Member
|
Approved - thanks! |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 30, 2018
* dotnet/dev15.7.x: Foreach to For refactoring (dotnet#25460) added more logging for completion to track some test failures where completion doesn't show up when it should have. (dotnet#25801) Add suggested stackalloc initializer tests (dotnet#25656) Addressed PR feedback. [SQLite] Fix continuous probing for sqlite Add missing file, update test for clearer output. Addressed PR feedback, updated ILocalFunctionOperation to final design specified in review. Added both ExpressionBody and BlockBody to the underlying BoundNode for local functions, and exposed both to IOperation consumers. Update PATH to our xcopy CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ompletion doesn't show up when it should have.
all these logging is No-op without logging enabled. and they are not enabled in product. only in test.
Customer scenario
This is test only change. this change doesn't do anything in product without test logging enabled.
Bugs this fixes
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/587964?src=alerts&src-action=summary_id_link
Workarounds, if any
no workaround
Risk
It doesn't do anything in production.
Performance impact
No impact
Is this a regression from a previous update?
No
Root cause analysis
DDRIT tests are sometimes failing because it expects completion set but it doesn't show up. right now, we only knows that whether it showed up or not, but no info on what happened internally. this should let us to have better idea on whether we even got the request, if we got the request, whether we reached the end and showed completion set or bailed out before that.
How was the bug found?
DDRIT