Skip some PDBUsingTests tests to unblock CI#25753
Conversation
|
So far it looks like a bug in DiaSymReader.Native (64-bit vs 32-bit). All tests pass using a newer DSRN build locally. |
|
Any idea how the bug got past CI and into the branch? I don't think those tests are new. |
|
No. We are pretty confused how this happen at this point. |
|
Failure looks to be random. See this run where the tests passed (other tests failude) https://ci.dot.net/job/dotnet_roslyn/job/dev15.7.x/job/windows_debug_unit32_prtest/870/console |
|
The bug only reproduces when running all (many) emit tests at once. It does not repro when running tests individually, not even when running the entire @jaredpar Any chance we changed bitness of the test runner recently? |
No. Nothing has changed in this area in some time. |
|
@tmat Sounds like we have a proper fix. Would you rather upgrade the DSRN package version directly, or should I move forward with this mitigation PR? |
|
Need to take this PR. This branch is on the floor due to the massive flakiness in tests. Not just PDB. PeekTests also causing major issues. If there is a fix later the skip can be reverted. |
|
@jcouv I do not have an official build yet. Proceed with this PR please. |
…features/dataflow * dotnet/dev15.7.x: Fix inference when tuple names differ (dotnet#25738) Avoid crash with 'new ref[]' (dotnet#25505) Skip some PDBUsingTests tests to unblock CI (dotnet#25753) Disable Spanish queue Tuple equality: Optimize cases where nullable always has value (dotnet#25644) Bump prerelease version to beta4 Fix failure to initialize RemoteWorkspace in the out-of-process host remove whitespace Removing package dependency for Microsoft.VisualStudio.Text.UI.Wpf in EditorFeatures Removing package dependency for Microsoft.VisualStudio.Text.UI.Wpf in CSharpEditorFeatures
Tagging @JieCarolHu @tmat @jaredpar
I don't know the root cause for this problem. But from thread, my understanding is that we'll skip those tests to unblock, and proceed with investigation of the issue to re-enable.
Bugs this fixes
Works around #25737