Skip to content

Add MetadataImportOptions to public compilation options constructor and add validation for the specified value.#25046

Merged
AlekseyTs merged 1 commit intodotnet:dev15.7.xfrom
AlekseyTs:Issue6748
Feb 27, 2018
Merged

Add MetadataImportOptions to public compilation options constructor and add validation for the specified value.#25046
AlekseyTs merged 1 commit intodotnet:dev15.7.xfrom
AlekseyTs:Issue6748

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs commented Feb 25, 2018

This is a follow-up for #24468

@AlekseyTs AlekseyTs added Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers labels Feb 25, 2018
@AlekseyTs AlekseyTs requested a review from a team February 25, 2018 20:25
@AlekseyTs AlekseyTs added this to the 15.7 milestone Feb 26, 2018
@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler Please review

1 similar comment
@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler Please review

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Feb 27, 2018

@jaredpar for ask-mode approval for 15.7. Thanks

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

Ping @jaredpar for ask-mode approval for 15.7. Thanks

@jaredpar
Copy link
Copy Markdown
Member

jaredpar commented Feb 27, 2018 via email

@AlekseyTs AlekseyTs merged commit ae36a41 into dotnet:dev15.7.x Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved to merge Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants