Added member classification support for c#.#24931
Merged
DustinCampbell merged 1 commit intodotnet:dev15.7.xfrom Feb 27, 2018
mkrueger:dev15.7.x-classification
Merged
Added member classification support for c#.#24931DustinCampbell merged 1 commit intodotnet:dev15.7.xfrom mkrueger:dev15.7.x-classification
DustinCampbell merged 1 commit intodotnet:dev15.7.xfrom
mkrueger:dev15.7.x-classification
Conversation
Member
|
I've re-kicked the CI tests that failed as they don't look related to this change. |
DustinCampbell
approved these changes
Feb 26, 2018
Contributor
|
looping @Pilchie for Ask mode approval for 15.7.Preview2 |
Member
|
Approved for 15.7 P2 - thanks @mkrueger ! |
Contributor
Author
|
Thanks @ALL for the help :) |
DavidKarlas
pushed a commit
to DavidKarlas/roslyn
that referenced
this pull request
May 26, 2018
MonoDevelop(VSfM) recently switched from using `Microsoft.CodeAnalysis.Classification.Classifier` to using `IAccurateClassifier` from VS API. But with this switch some classifications that were added in dotnet#24931 stopped working. Reason for this is that in that commit new classifications were filtered out by converting back to classification that was used before `ClassificationTypeNames.Identifier` so VS Windows would continue working fine. But later in dotnet#25723 this ClassificationTypes were added so I assume with removing this filtering VS Windows will work just fine since ClassificationTypes that were added dotnet#25723 have BaseType `ClassificationTypeNames.Identifier`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #24100
Added classification for c# methods, events, fields and properties.
VB.NET is missing and unit tests. I've atm problems compiling/running the tests on my system. So do not merge it - it's untested.
But that's basically what we need in Visual Studio 4 Mac. It should be a base for discussion about classification enhancements.
esp. for making a difference between properties, events and fields this is useful.