Skip to content

CS1628 error text mentions in parameters; fixes #24584#24585

Merged
jaredpar merged 1 commit intodotnet:dev15.7.xfrom
jbogard:in-param-exception
Feb 1, 2018
Merged

CS1628 error text mentions in parameters; fixes #24584#24585
jaredpar merged 1 commit intodotnet:dev15.7.xfrom
jbogard:in-param-exception

Conversation

@jbogard
Copy link
Contributor

@jbogard jbogard commented Feb 1, 2018

Updated ERR_AnonDelegateCantUse error text to mention in parameters. Updated a failing test, too.

@jbogard jbogard requested a review from a team as a code owner February 1, 2018 19:15
@jaredpar
Copy link
Member

jaredpar commented Feb 1, 2018

@jbogard thanks for the contribution! Can you retarget this PR to dev15.7.x instead of master? That's where compiler fixes are going at the moment.

@jaredpar
Copy link
Member

jaredpar commented Feb 1, 2018

CC @dotnet/roslyn-compiler

@jbogard jbogard changed the base branch from master to dev15.7.x February 1, 2018 20:58
@jaredpar
Copy link
Member

jaredpar commented Feb 1, 2018

Hmm, you made need to rebase as well. Sorry should have thought to mention that. 😦

@jbogard jbogard force-pushed the in-param-exception branch from 0c6737a to 6aade2a Compare February 1, 2018 21:01
@jbogard
Copy link
Contributor Author

jbogard commented Feb 1, 2018

@jaredpar rebase is my middle name

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!!

@jaredpar jaredpar merged commit d98d6fa into dotnet:dev15.7.x Feb 1, 2018
@jbogard jbogard deleted the in-param-exception branch February 1, 2018 22:03
pedroreys added a commit to pedroreys/roslyn that referenced this pull request Apr 2, 2018
Fix the pt-BR translation after the changes from PR dotnet#24585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants