Merged
Conversation
The last await-containing expression in an argument triggers spilling of all argument before it. The value of the expression itself, however, should not be spilled. (there are no awaits after it) Agreesive spilling may result in substandard codegenration and/or unexpected errors.
VB does not have this particular bug and corresponding scenario works correctly. There are however other bugs beyond the scope of what is fixed in this PR.
…g-text * dotnet/dev15.6.x: Fix symbol completion after 'in' (#24335) use PascalCase for const name Limit compiler server pipe name length (#24265) Test ConvertedType on LHS of deconstruction-assignment (#24158) remove unused usings use .editorconfig files address more comments address code review comments move newly added text into resource file add text and hyperlink to C# code style page
Fix a case where the stack spiller spills more than needed. (possibly resulting in false errors)
#24332) * make sure OOP inherit same culture as VS otherwise culture sensitive resource such as xml doc comment will not work properly * don't crash on expected issue
Update string text for keybindings reset.
agocke
approved these changes
Jan 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.6.x into dev15.7.x.
git fetch --all git checkout merges/dev15.6.x-to-dev15.7.x-20180122-080019 git reset --hard upstream/dev15.7.x git merge upstream/dev15.6.x # Fix merge conflicts git commit git push merges/dev15.6.x-to-dev15.7.x-20180122-080019 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.