Fix symbol completion after 'in'#24335
Merged
jcouv merged 1 commit intodotnet:dev15.6.xfrom Jan 19, 2018
Merged
Conversation
jinujoseph
approved these changes
Jan 19, 2018
Member
Author
|
Test windows_release_unit64_prtest please |
Member
Author
|
@Pilchie for ask-mode approval for 15.6. Thanks |
Pilchie
approved these changes
Jan 19, 2018
Member
|
Approved, thanks @jcouv |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 19, 2018
…g-text * dotnet/dev15.6.x: Fix symbol completion after 'in' (dotnet#24335) use PascalCase for const name Limit compiler server pipe name length (dotnet#24265) Test ConvertedType on LHS of deconstruction-assignment (dotnet#24158) remove unused usings use .editorconfig files address more comments address code review comments move newly added text into resource file add text and hyperlink to C# code style page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dotnet/roslyn-ide for review, for 15.6
Customer scenario
When typing a method or lambda declaration with an
inparameter, symbol completion should be offered for the type of the parameter.When invoking a method with an
inargument, symbol completion should be offered for the expression of the argument.Bugs this fixes
Fixes #24326
Workarounds, if any
Type without IntelliSense.
Risk
Performance impact
Low. This is adding an additional case for
inin a few places that already had cases forrefandout.Is this a regression from a previous update?
No.
How was the bug found?
Partly reported by customer. I found the second part from cursory manual validation.
Tagging @VSadov @OmarTawfik as FYI