Merged
Conversation
The new analyzer warnings are valid but are quite noisy. Going to suppress them for now to unblock this upgrade. Will fix them in a separate change.
Move to xunit 2.3.1
On MacOS pipes are implemented using Unix domain sockets. Unix domain sockets must have a valid file path for their endpoint. The best place is in the temp folder. Unfortunately, domain sockets on Unix also have a very small path length limit of 104 characters. In addition, Mac temp paths can be very long since they include randomly generated characters from the OS. In total, this means that Roslyn has barely 50 characters worth of space for its pipe identifiers. This change cuts down on the bytes of the SHA256 hash used. This shouldn't affect the security of the pipe, since the hash isn't used as a security boundary, but should fit the pipe name into the length limitations. Fixes #24137
agocke
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.6.x into dev15.7.x.
git fetch --all git checkout merges/dev15.6.x-to-dev15.7.x-20180118-234432 git reset --hard upstream/dev15.7.x git merge upstream/dev15.6.x # Fix merge conflicts git commit git push merges/dev15.6.x-to-dev15.7.x-20180118-234432 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.