Merged
Conversation
The new analyzer warnings are valid but are quite noisy. Going to suppress them for now to unblock this upgrade. Will fix them in a separate change.
Member
Author
|
CC @AlekseyTs, @agocke |
Member
|
How does this relate to #24163? |
Member
Author
|
@jasonmalinowski it separates the concerns of moving to new xunit from enabling testing inside VS. One is required for featurce work, the other is an aspiration that must wait for a bunch of perf validation to finish. |
sharwell
approved these changes
Jan 17, 2018
agocke
approved these changes
Jan 17, 2018
jasonmalinowski
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to unblock some of our feature work which depends on using netcore2.1.
This also brought along a new batch of xunit analyzer warnings. I've suppressed them for the time being, as we've done with other xunit ones. I have a fix for several but I wanted to separate it out to a different change as the code churn is quite large.