Add Xunit adapter to enable testing in VS#24163
Conversation
There was a problem hiding this comment.
Can we file bugs for all of these cases? Seems like these are hiding real issues
sharwell
left a comment
There was a problem hiding this comment.
Marking as request changes only while I run through developer scenarios today with this in 15.6 Preview 2 to make sure nothing is broken.
|
📝 I'm halfway through the day. Subjective evaluation is showing a consistent move towards not being viable. While it's possible that something could change and the painful parts of the experience get avoided, at this point it appears unlikely. |
|
@sharwell - are you trying this on preview 3 builds? |
|
I'm testing on 15.6 Preview 2. I'll follow up after my work is complete with the observed (objective) results. |
|
This is still really bad on Preview 3. I'm still in the process of investigating the cause so things can be improved, but we're going to have to move this PR to Preview 4 at the earliest. |
5045e73 to
78141ee
Compare
|
@jasonmalinowski @Pilchie Can you review the updated documentation in the final commit of this PR? I'm planning to merge on successful build and notify the team. 😄 |
| <Target Name="RemoveDuplicateXUnitContent"> | ||
| <ItemGroup> | ||
| <Content Remove="@(Content)" Condition="'%(Filename)%(Extension)' == 'xunit.abstractions.dll'" /> | ||
| <None Remove="@(None)" Condition="'%(Filename)%(Extension)' == 'xunit.abstractions.dll'" /> |
There was a problem hiding this comment.
@sharwell Is this still needed? Content would have caused a double write, but None should have been ignored?
There was a problem hiding this comment.
No description provided.