Add Razor options service in response to Roslyn changes#3768
Merged
allisonchou merged 7 commits intomain-vs-depsfrom Jun 18, 2021
Merged
Add Razor options service in response to Roslyn changes#3768allisonchou merged 7 commits intomain-vs-depsfrom
allisonchou merged 7 commits intomain-vs-depsfrom
Conversation
allisonchou
commented
Jun 11, 2021
...soft.VisualStudio.LanguageServerClient.Razor/Feedback/RazorFeedbackDiagnosticFileProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
There seem to be a few NuGet version conflicts causing the tests for fail, but for some reason I can't get the errors to repro locally on my machine. :( Will take a closer look tomorrow. |
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@dotnet/razor-tooling This should now be ready to review whenever anyone has some time. Everything appears to be working, with two caveats:
|
NTaylorMullen
approved these changes
Jun 18, 2021
| <MicrosoftVisualStudioShellPackagesVersion>17.0.0-preview-2-31228-438</MicrosoftVisualStudioShellPackagesVersion> | ||
| <MicrosoftVisualStudioPackagesVersion>17.0.35-gdeb9415fdc</MicrosoftVisualStudioPackagesVersion> | ||
| <RoslynPackageVersion>3.10.0-2.21179.6</RoslynPackageVersion> | ||
| <RoslynPackageVersion>4.0.0-3.21317.9</RoslynPackageVersion> |
There was a problem hiding this comment.
/cc @genlu Allison got your back! (he mentioned how he was seeing some unexpected assembly loads in another convo)
...soft.VisualStudio.LanguageServerClient.Razor/Feedback/RazorFeedbackDiagnosticFileProvider.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionsService.cs
Show resolved
Hide resolved
NTaylorMullen
pushed a commit
that referenced
this pull request
Jun 21, 2021
This reverts commit 2f73ca5.
NTaylorMullen
pushed a commit
that referenced
this pull request
Jun 22, 2021
This reverts commit 2f73ca5.
NTaylorMullen
pushed a commit
that referenced
this pull request
Jun 29, 2021
This reverts commit 2f73ca5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes:
dotnet/aspnetcore#32555