Skip to content

Add Razor options service in response to Roslyn changes#3768

Merged
allisonchou merged 7 commits intomain-vs-depsfrom
allichou/AddRazorOptionsService2
Jun 18, 2021
Merged

Add Razor options service in response to Roslyn changes#3768
allisonchou merged 7 commits intomain-vs-depsfrom
allichou/AddRazorOptionsService2

Conversation

@allisonchou
Copy link
Contributor

@allisonchou allisonchou commented Jun 11, 2021

Summary of the changes

  • Responding to Roslyn changes in [LSP] Add Razor options provider to Roslyn roslyn#53879 which adds a Razor options service.
  • When implementing the Roslyn side, I tested out the changes in Razor and everything seemed to work. However, I can't currently test with the final upgraded packages versions because my dev17 build appears to be busted. 🤦‍♀️ so while I'm pretty confident that these changes work since I tested them before, I wasn't able to do a final test to make sure.

Fixes:
dotnet/aspnetcore#32555

@allisonchou
Copy link
Contributor Author

There seem to be a few NuGet version conflicts causing the tests for fail, but for some reason I can't get the errors to repro locally on my machine. :( Will take a closer look tomorrow.

@NTaylorMullen
Copy link

There seem to be a few NuGet version conflicts causing the tests for fail, but for some reason I can't get the errors to repro locally on my machine. :( Will take a closer look tomorrow.

dotnet nuget locals all -c should get your box into a similar state

@allisonchou
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@allisonchou
Copy link
Contributor Author

allisonchou commented Jun 18, 2021

@dotnet/razor-tooling This should now be ready to review whenever anyone has some time. Everything appears to be working, with two caveats:

  1. Having an .editorconfig may still mess up override completion in Razor files (i.e. you'll still observe the original issue). This can occur if the .editorconfig C# tabs/spaces options differ from the Tools->Options C# tabs/spaces options. I believe this is due to the .editorconfig options provider taking precedence over the Razor options provider. I'm thinking we may want to completely disable the .editorconfig options provider for Razor files until we have proper support for .editorconfig. I think this can be done in a follow-up PR on the Roslyn side.
  2. As previously discussed offline, I'm seeing VS hang whenever trying to commit an override completion item for the first time. Taylor mentioned he wasn't able to repro this, so I'm hoping it's just a "me" problem. Filed a feedback ticket with a dump here: https://developercommunity.visualstudio.com/t/razor-ide-hangs-when-trying-to-commit-override-com/1453744

<MicrosoftVisualStudioShellPackagesVersion>17.0.0-preview-2-31228-438</MicrosoftVisualStudioShellPackagesVersion>
<MicrosoftVisualStudioPackagesVersion>17.0.35-gdeb9415fdc</MicrosoftVisualStudioPackagesVersion>
<RoslynPackageVersion>3.10.0-2.21179.6</RoslynPackageVersion>
<RoslynPackageVersion>4.0.0-3.21317.9</RoslynPackageVersion>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @genlu Allison got your back! (he mentioned how he was seeing some unexpected assembly loads in another convo)

@allisonchou allisonchou merged commit 2f73ca5 into main-vs-deps Jun 18, 2021
@allisonchou allisonchou deleted the allichou/AddRazorOptionsService2 branch June 18, 2021 20:10
NTaylorMullen pushed a commit that referenced this pull request Jun 21, 2021
NTaylorMullen pushed a commit that referenced this pull request Jun 22, 2021
NTaylorMullen pushed a commit that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants