Respond to Roslyn adding Razor options service#3719
Closed
allisonchou wants to merge 4 commits intomainfrom
Closed
Respond to Roslyn adding Razor options service#3719allisonchou wants to merge 4 commits intomainfrom
allisonchou wants to merge 4 commits intomainfrom
Conversation
allisonchou
commented
Jun 4, 2021
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/DefaultDynamicDocumentContainer.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionsProvider.cs
Outdated
Show resolved
Hide resolved
NTaylorMullen
approved these changes
Jun 4, 2021
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/DefaultDynamicDocumentContainer.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionsProvider.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionsProvider.cs
Outdated
Show resolved
Hide resolved
allisonchou
commented
Jun 5, 2021
...azor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionSetProvider.cs
Outdated
Show resolved
Hide resolved
NTaylorMullen
approved these changes
Jun 6, 2021
...azor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionSetProvider.cs
Outdated
Show resolved
Hide resolved
...azor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorDocumentOptionSetProvider.cs
Outdated
Show resolved
Hide resolved
davidwengier
approved these changes
Jun 7, 2021
Contributor
Author
|
So I changed the logic here again due to changes on the Roslyn side. 😅 at this point, I think it might be best for the Roslyn side to get totally signed off + merged before I start pinging people for reviews here on the Razor side. |
Contributor
Author
|
Closing in favor of #3768, since I believe the changes need to target -vs-deps due to the package dependency requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes:
https://github.com/dotnet/aspnetcore/issues/32555