Clean up LanguageServerFeatureOptions#12540
Merged
davidwengier merged 17 commits intodotnet:mainfrom Dec 1, 2025
Merged
Conversation
Everything always used the same value
Use the client capabilities instead
We weren't offering Razor completion items in Html contexts when triggering with a space, but seems like we should only avoid calling their Html server. Also moved around a bunch of tests that hid this, as they started failing.
Everything used the same value
It was always true
Value is always true
ToddGrun
reviewed
Dec 1, 2025
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Completion/RazorCompletionEndpoint.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
approved these changes
Dec 1, 2025
Member
DustinCampbell
left a comment
There was a problem hiding this comment.
This is just lovely! I'm thrilled to see so many of these old, crusty options go away.
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Completion/RazorCompletionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Definition/DefinitionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hover/HoverEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/AbstractRazorDelegatingEndpoint.cs
Show resolved
Hide resolved
...c/Microsoft.CodeAnalysis.Razor.Workspaces/Completion/CompletionTriggerAndCommitCharacters.cs
Outdated
Show resolved
Hide resolved
...icrosoft.AspNetCore.Razor.LanguageServer.Test/Definition/DefinitionEndpointDelegationTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that VS Code is cohosting only, most of the toggles that LanguageServerFeatureOptions allowed us to make don't make any sense.
You'd be mad not to look at this commit-at-a-time. I was almost going to split it up over multiple PRs, but each PR would just be one commit, and they'd all have to stack, so I didn't think it was worth the complexity.
Part of #12491
Fixes #12176
Fixes #11594